-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to dynamic linked VCRT #657
Conversation
I thought we were only having a problem internally for DEBUG builds? Could we use dynamic CRT only for debug? |
I believe we're always linking with DLLs internally, which is the fundamental problem - we've got different build configurations internally and externally. This aligns all our builds to be the same. |
Internally should be matching Windows internal builds, which is to partially statically link the CRT (which we also do in Windows). |
I'm just describing how OneBranch is actually building our binaries, e.g. xdpapi.dll imports:
The point of this PR is mainly to replicate the same missing debug CRT issue we are hitting on internal builds, and to provide a solution. The work to take a dependency on the framework-for-a-framework is #605 which is lower priority. |
Technically a breaking change. We need to use dynamic linking to VCRT in our internal, official builds for the debug flavor, so we should use it everywhere.