Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix macro guard version for NET_BUFFER_LIST_IS_TCP_RSC_SET #591

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

mtfriesen
Copy link
Contributor

@mtfriesen mtfriesen commented Jul 18, 2024

The build is failing on internal WDKs newer than WS2022.

@mtfriesen mtfriesen added bug Something isn't working build Related to building/compiling the code labels Jul 18, 2024
@mtfriesen mtfriesen requested a review from a team as a code owner July 18, 2024 16:41
csujedihy
csujedihy previously approved these changes Jul 18, 2024
@csujedihy
Copy link
Contributor

Looks like it already exists in Ni?

@csujedihy csujedihy dismissed their stale review July 18, 2024 16:50

build failed

@mtfriesen
Copy link
Contributor Author

Looks like it already exists in Ni?

Ugh! The problem is these got backported post-release, so they're both in Ni and not in Ni, depending on which version of the WDK you have.

nibanks
nibanks previously approved these changes Jul 18, 2024
@mtfriesen mtfriesen merged commit 3435c55 into main Jul 18, 2024
29 checks passed
@mtfriesen mtfriesen deleted the mtfriesen/rsc_macro_ver branch July 18, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to building/compiling the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants