Use Windows Artifact Format #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-windows into win-output-format
|
This passed an internal build and produces the right artifacts. |
mtfriesen
reviewed
Jun 25, 2024
| <WiXPackagePath>$(SolutionDir)packages\wix.3.14.1\</WiXPackagePath> | ||
| <WntPackagePath>$(SolutionDir)packages\win-net-test.0.5.2\</WntPackagePath> | ||
| <!-- Configuration properties to match Windows --> | ||
| <WinConfig Condition="'$(Configuration)' == 'Release'">fre</WinConfig> |
There was a problem hiding this comment.
is this because all the scripts invoke the build as debug/release instead of fre/chk, and so on?
There was a problem hiding this comment.
Yes. Those are unchanged.
mtfriesen
reviewed
Jun 25, 2024
| [string]$Arch | ||
| ) | ||
|
|
||
| # Convert to Windows format |
There was a problem hiding this comment.
i saw more conversions in the xdp.props file:
<WinPlat Condition="'$(Platform)' == 'Win32'">x86</WinPlat>
<WinPlat Condition="'$(Platform)' == 'x64'">amd64</WinPlat>
<WinPlat Condition="'$(Platform)' == 'ARM64'">arm64</WinPlat>
<WinPlat Condition="'$(Platform)' == 'ARM64EC'">arm64ec</WinPlat>
should we transform all of those here, too?
There was a problem hiding this comment.
Since we don't support anything else in the project, I think it's fine as is for now.
mtfriesen
approved these changes
Jun 26, 2024
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated XDP to use the Windows artifact directory format (i.e., arm64chk or amd64fre), which is needed for internal build alignment.
Future changes may further refactor the project files to use /~https://github.com/microsoft/undocked instead of manually doing parts of this.