Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically restart ts server after disableAutomaticTypeAcquisition config changed #32412

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Conversation

yume-chan
Copy link
Contributor

Now Code will automatically restart TypeScript server when some config about TypeScript has been changed, but why not for typescript.disableAutomaticTypeAcquisition?

This pull request adds the detection for typescript.disableAutomaticTypeAcquisition config and restart TypeScript server when it is changed.

@mention-bot
Copy link

@CnSimonChan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dbaeumer and @egamma to be potential reviewers.

@msftclas
Copy link

@CnSimonChan,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@CnSimonChan, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@mjbvz mjbvz added this to the August 2017 milestone Aug 16, 2017
@mjbvz mjbvz merged commit 0e18b05 into microsoft:master Aug 16, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 16, 2017

Thanks @CnSimonChan!

This change will be in the next VSCode insiders build

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants