Editor inputs have contributed commands in the context menu

[jrieken]

re #89333

• focus SCM input
• show context menu
• the is a entry "Command Palette..." which is awkward

[gjsjohnmurray]

Related to this, on my system that context menu also gives me entries that have been contributed by a couple of my extensions.

[deepak1556]

Same issue on macOS as well

[joaomoreno]

This happens across all our inputs which use the Editor. IMO we should not include all those contributions and should just have Cut, Copy & Paste in that menu.

What's the simplest way towards this @alexdima?

[alexdima]

@joaomoreno The "Command Palette..." should potentially have a better context key for precondition, not undefined:

vscode/src/vs/workbench/contrib/quickopen/browser/commandsHandler.ts

Line 216 in 4e27cff

precondition: undefined,

[joaomoreno]

@alexdima Thanks! But this is actually only half of the story. As @gjsjohnmurray mentions, extension contributed commands show up:

Should we file issues to these extensions, suggesting to change their when clauses?

[jrieken]

It might be better/simpler to have another menu id, something like embeddedEditorContext or even something SCM specific

[alexdima]

To reproduce, you can use:

"menus": [
    "editor/context/copy": [{
        "command": "workbench.action.toggleDevTools"
    }]
]