fix: clear JsonSchemaService local single resource cache on schema change
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Sep 5, 2021
| @@ -273,6 +273,9 @@ export class JSONSchemaService implements IJSONSchemaService { | |||
| } | |||
|
|
|||
| public onResourceChange(uri: string): boolean { | |||
| // always clear this local cache when a resource changes | |||
| this.cachedSchemaForResource = undefined; | |||
There was a problem hiding this comment.
Perhaps this could be more fine targeted, but I'm not sure it's worth the complexity.
dsherret
commented
Sep 5, 2021
|
|
||
| // now ensure validation occurs with the new schema | ||
| validation = await ls.doValidation(testDoc.textDoc, testDoc.jsonDoc); | ||
| assert.deepStrictEqual(validation.map(v => v.message), []); |
There was a problem hiding this comment.
Previously this would use the resource on this.cachedSchemaForResource instead of the latest cache so it would get the previous diagnostics.
|
Thanks a lot @dsherret ! |
dsherret
deleted the
clear-json-schema-service-local-single-resource-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This local cache was not being cleared on a resource change.
Closes #106