Update schema for cacheVariables #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gugavaro This PR affects the schema and we will want to bring the changes back to VS too. |
…t/vscode-cmake-tools into bobbrow/buildTypeSchema
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #1934
The schema was too strict for CMAKE_BUILD_TYPE and rejected environment references. It was also missing support for
nullwhich is a valid way to clear the value of a variable for a given preset.The object support was removed as I don't believe it is valid for
CMAKE_BUILD_TYPE.NOTE FOR REVIEWERS: You should "hide whitespaces changes" to see the actual changes in the file. The indentation of the entire file was off by 2 which caused enough pain editing the schema that I reformatted the file as part of this.