Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locate CmakeLists.txt in root's subfolders #1803

Merged
merged 13 commits into from
Jun 23, 2021
Merged

locate CmakeLists.txt in root's subfolders #1803

merged 13 commits into from
Jun 23, 2021

Conversation

elahehrashedi
Copy link
Contributor

@elahehrashedi elahehrashedi commented Apr 22, 2021

fix: #533

if there is no cmakelists in the root this will be shown:
image

Then you hit on "Locate",

in case there are few cmakelists files in subdirectories this will be shown:
image

in case there is no cmakelists file in the root this will be shown:
image

@elahehrashedi elahehrashedi requested review from andreeis and bobbrow and removed request for andreeis April 22, 2021 17:55
@andreeis andreeis added this to the 1.8.0 milestone Apr 22, 2021
@elahehrashedi elahehrashedi changed the title Ella/locatecmake2 locate CmakeLists.txt in root's subfolders Apr 22, 2021
Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted a few comments.

@elahehrashedi elahehrashedi requested a review from bobbrow June 18, 2021 20:00
@bobbrow bobbrow merged commit 134b95c into develop Jun 23, 2021
@bobbrow bobbrow deleted the ella/locatecmake2 branch June 23, 2021 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a quickPick of all the CMakeLists.txt inside the project (if not in the root)
3 participants