Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting package references from csproj from multiple item groups #3603

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix getting package references from csproj from multiple item groups #3603

merged 2 commits into from
Mar 2, 2023

Conversation

alexweininger
Copy link
Member

No description provided.

@alexweininger alexweininger requested a review from a team as a code owner March 1, 2023 20:31
MicroFish91
MicroFish91 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@MicroFish91 MicroFish91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@alexweininger
Copy link
Member Author

FYI there also can be more than one *.csproj file in a typical C# project. We're currently finding all *.csproj files and then searching the first one. This will create problems for cases where there is more than one *.csproj file.

@alexweininger alexweininger merged commit 9e27857 into main Mar 2, 2023
@alexweininger alexweininger deleted the alex/sapphire-hare branch March 2, 2023 02:17
@microsoft microsoft locked and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MicroFish91 MicroFish91 MicroFish91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweininger @MicroFish91