VSTHRD003 analyzer false positive fixes #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect returned from an invocation We assume that the method is returning something fresh, such that the accessed Task belongs to the caller's context.
BertanAygun
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to the Microsoft.VisualStudio.Threading.Analyzers.CSharp codebase includes modifications to the
AnalyzeAwaitExpressionmethod to support returning members of a parameter in a lambda, as well as new tests to verify that warnings are not reported in specific scenarios involving awaiting task properties and returning tasks from lambda arguments.Main changes:
src/Microsoft.VisualStudio.Threading.Analyzers.CSharp/VSTHRD003UseJtfRunAsyncAnalyzer.cs: Modified theAnalyzeAwaitExpressionmethod to allow returning members of a parameter in a lambda.test/Microsoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD003UseJtfRunAsyncAnalyzerTests.cs: Added three new tests to verify that warnings are not reported in specific scenarios involving awaiting task properties and returning tasks from lambda arguments. [1] [2] [3]Testing improvements:
test/Microsoft.VisualStudio.Threading.Analyzers.Tests/Helpers/CSharpCodeFixVerifier``2+Test.cs: UpdatedCreateParseOptionsmethod inCSharpCodeFixVerifierto set language version to CSharp11.