Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSTHRD004 fires for SwitchToMainThreadAsync().NoThrowAwaitable() #1232

Closed
sharwell opened this issue Sep 13, 2023 · 0 comments · Fixed by #1243
Closed

VSTHRD004 fires for SwitchToMainThreadAsync().NoThrowAwaitable() #1232

sharwell opened this issue Sep 13, 2023 · 0 comments · Fixed by #1243
Assignees
@AArnott
Labels
analyzers bug

Comments

@sharwell
Copy link
Member

Bug description

VSTHRD004 doesn't recognize the NoThrowAwaitable extension added in #1194.

Repro steps

await jtf.SwitchToMainThreadAsync(cancellationToken).NoThrowAwaitable();

Expected behavior

No warning reported

Actual behavior

VSTHRD004 reported

  • Version used: 17.7.30
  • Application (if applicable): Visual Studio

Additional context

Add any other context about the problem here.
@sharwell sharwell mentioned this issue Sep 13, 2023
Merged
@AArnott AArnott self-assigned this Oct 23, 2023
AArnott added a commit to AArnott/vs-threading that referenced this issue Oct 23, 2023
@AArnott
Fix VSTHRD004 mis-fire on NoThrowAwaitable()
047a498 
Fixes microsoft#1232
@AArnott AArnott mentioned this issue Oct 23, 2023
Merged
sharwell added a commit to dotnet/roslyn that referenced this issue Nov 10, 2023
@sharwell
Update threading analyzers
d3f767a 
See microsoft/vs-threading#1232
This was referenced Dec 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
analyzers bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix VSTHRD004 mis-fire on NoThrowAwaitable() AArnott/vs-threading
2 participants
@AArnott @sharwell