Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make facade_builder a class type, rather than a type alias #129

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Make facade_builder a class type, rather than a type alias #129

merged 2 commits into from
Jul 11, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Jul 11, 2024

As a documented class type, facade_builder shall not be a type alias. No behavior changes.

@mingxwa mingxwa requested review from tian-lt and guominrui July 11, 2024 03:38
@mingxwa mingxwa self-assigned this Jul 11, 2024
@mingxwa mingxwa merged commit 867f9e9 into microsoft:main Jul 11, 2024
4 checks passed
@mingxwa mingxwa deleted the users/mingxwa/struct-facade-builder branch July 11, 2024 12:57
@mingxwa mingxwa mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tian-lt tian-lt tian-lt approved these changes

@guominrui guominrui Awaiting requested review from guominrui

Assignees

@mingxwa mingxwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingxwa @tian-lt