Update Key Vault to use Azure RBAC #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcfarland
reviewed
Jun 26, 2024
added 2 commits
June 26, 2024 16:26
mmcfarland
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates our deployment to use Azure RBAC for key vault access, rather than the classic Key Vault access policies. This is deployed to staging.
Some of the unused KEDA stuff needed to be removed manually (otherwise the helm install failed with
Error: customresourcedefinitions.apiextensions.k8s.io "triggerauthentications.keda.sh" not found).To confirm the fix, I
pctasks dataset ingest-collection -d ~/src/Microsoft/planetary-computer-tasks/datasets/ecmwf-forecast/dataset.yaml -su, which failed because pctasks couldn't read the secret from the keyvault.