#70 Visual Studio crashes when I quit debugging #526
Conversation
- Fix potential NullReferenceExceptions
| if (Tree != ProjectEntry.Tree) { | ||
| // we were enqueued and a new version became available, don't re-analyze against | ||
| // the old version. | ||
| if (Ast != null && ProjectEntry != null && ProjectEntry.Tree != null && Tree != ProjectEntry.Tree) { |
There was a problem hiding this comment.
Should these ever be null? Is it safe to fall through to the remaining code if they are?
There was a problem hiding this comment.
I couldn't reproduce this issue, so I'm not entirely sure (there are null checks for these properties elsewhere in the code, so I presumed it would be safe enough here.) This is something I plan on asking dino today before merging in.
There was a problem hiding this comment.
I'm going to at least Assert here, so that we can catch it in debug builds.
There was a problem hiding this comment.
Okay... just reviewed this again with my alter ego from the future, and realized I was being an idiot. I intended to null check and not to flow through, and I totally misinterpreted your comment. fixed 😃
|
Minor comment, else 👍 |
#70 Visual Studio crashes when I quit debugging
fix #70