Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2015 stop working if changes any code while debugging(1.1 rc3) #584

Closed
alanpurple opened this issue Nov 10, 2015 · 17 comments
Closed

VS 2015 stop working if changes any code while debugging(1.1 rc3) #584

alanpurple opened this issue Nov 10, 2015 · 17 comments

Comments

@alanpurple
Copy link

VS2015 stop working if I change something and save

@mousetraps
Copy link
Contributor

Cant repro this. Can you please provide more info? What do you mean by "stops working"? Can you provide simple repro steps starting from one of the project templates? Or do you have a project you can send us where you can reproduce the issue consistently?

@alanpurple
Copy link
Author

Crash I mean
On Nov 12, 2015 7:02 AM, "Sara Itani" notifications@github.com wrote:

Cant repro this. Can you please provide more info? What do you mean by
"stops working"? Can you provide simple repro steps starting from one of
the project templates? Or do you have a project you can send us where you
can reproduce the issue consistently?


Reply to this email directly or view it on GitHub.

@mousetraps
Copy link
Contributor

Thanks, but that's really not enough information for us to do anything about it...

  • since it was a crash, there should be a corresponding entry in the Windows event log, and grabbing the stack trace from that is necessary for us to track this down if we can't reproduce the issue.
  • what are steps to reproduce the issue?
  • can you reproduce the issue consistently?
  • on which projects types does it occur? does it occur in a basic console app?

@alanpurple
Copy link
Author

@mousetraps
just for any nodejs project,
press F5 for start debugging
and then modify any file which is included in the process, and then ctrl+s and immediately you can see the VS2015 stops working message

If you still can't reproduce this, I will provide a log, tell me, anyway now I'm outside so I can work later

VS version - VS 2015 community, nodejstool 1.1 rc3

@aruneshchandra
Copy link
Member

@alanpurple please provide the log if you can. Also, can you repro this consistently ?

Is anybody else having this issue ? it will be helpful for us to understand how widespread is this issue.

@kant2002
Copy link
Contributor

I have similar issue before 1.1rc3. It was sporadic, but I lately avoid debugging in NTVS since it is start using much more memory, and I have to restart VS

@billti
Copy link
Member

billti commented Nov 13, 2015

Looks potentially the same as #589 .

@zhengbli
Copy link

@kant2002 @alanpurple Are you guys on node v5? It runs fine for me on VS 2013 and VS 2015 with node v4.2, though I can indeed repro the crash on node v5, so I wonder if it is related.

@alanpurple
Copy link
Author

@zhengbli yes, node 5.0

@mousetraps I think this is same as #589 as billti said, still need a log?

@kant2002
Copy link
Contributor

@zhengbli I was on 0.12, but I have something like that just couple times. Not 100% sure that this was exactly this issue. Could try to reproduce

@mousetraps
Copy link
Contributor

@alanpurple It's your call. If you think it's the same issue, and I believe it is - great, let's close this as a dupe. But if for some unforeseeable reason it turns out to be a different issue, we won't fix it, and you'll keep running into it.
Basically, the more info we have, the more likely (and sooner) any given issue will be fixed. We really don't like going back and forth trying to extract out a simple piece of information or otherwise guess a machine setup.
So yes, now that we can reproduce, it probably doesn't matter. But please please please send us more info in the future.
Sent from my Rotary Phone

On Sat, Nov 14, 2015 at 1:37 AM -0800, "alanpurple" notifications@github.com wrote:
@zhengbli yes, node 5.0

@mousetraps I think this is same as #589 as billti said, still need a log?


Reply to this email directly or view it on GitHub:
#584 (comment)

@alanpurple
Copy link
Author

@mousetraps Sorry for late response, I've been outside lately
Here's a log

Faulting application name: devenv.exe, version: 14.0.23107.0, time stamp: 0x559b7ead
Faulting module name: KERNELBASE.dll, version: 10.0.10586.0, time stamp: 0x5632da1c
Exception code: 0xe0434352
Fault offset: 0x000bd8a8
Faulting process id: 0x368
Faulting application start time: 0x01d11f7b97527969
Faulting application path: C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\devenv.exe
Faulting module path: C:\WINDOWS\SYSTEM32\KERNELBASE.dll
Report Id: 7e14acee-f291-404d-94b5-6935531b7499
Faulting package full name:
Faulting package-relative application ID:

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ArgumentNullException
at Newtonsoft.Json.Linq.JToken.EnsureValue(Newtonsoft.Json.Linq.JToken)
at Newtonsoft.Json.Linq.JToken.op_Explicit(Newtonsoft.Json.Linq.JToken)
at Microsoft.NodejsTools.Debugger.Commands.ChangeLiveCommand.ProcessResponse(Newtonsoft.Json.Linq.JObject)
at Microsoft.NodejsTools.Debugger.Communication.DebuggerClient+d__3.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at Microsoft.NodejsTools.Debugger.NodeDebugger+d__98.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at Microsoft.NodejsTools.Debugger.NodeDebugger+d__62.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at Microsoft.NodejsTools.Debugger.DebugEngine.AD7Engine+<>c__DisplayClass103_0+<b__0>d.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at Microsoft.NodejsTools.Debugger.Communication.DebuggerClient+d__4.MoveNext()
at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.b__6_0(System.Object)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.DispatcherOperation.InvokeImpl()
at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object)
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
at System.Windows.Threading.DispatcherOperation.Invoke()
at System.Windows.Threading.Dispatcher.ProcessQueue()
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)

@mousetraps mousetraps self-assigned this Nov 15, 2015
mousetraps added a commit to mousetraps/nodejstools that referenced this issue Nov 15, 2015
…s v5

- v8 has recently removed the "stack_update_needs_step_in" property in
  responses. It looks like it always returned the same value as
  "stack_modified" anyways, so go ahead an remove the property altogether.
  https://codereview.chromium.org/1247363002/diff/1/src/liveedit-debugger.js
mousetraps added a commit that referenced this issue Nov 17, 2015
#584 VS2015 crashes if change code while debugging w/ Node.js v5
@syagev
Copy link

syagev commented Dec 2, 2015

Experiencing the exact same issue including identical crash logs.

@billti
Copy link
Member

billti commented Dec 2, 2015

@syagen - did you update to the final 1.1 release? The fix went into that build, so if you are running something earlier, you should expect the same crash and logs.

@syagev
Copy link

syagev commented Dec 3, 2015

@billti - indeed! I'm now hot swapping code smoothly. Thanks! ;)

@fuzzylogic7236
Copy link

Turn off "Edit and Continue". That solved it for me.

@mousetraps
Copy link
Contributor

the fix is available in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants