Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate debug logs when using task.exec* wrappers #1071

Merged

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Sep 30, 2024

Issue #1069

We already subscribe to debug events in the tool function

So no need to do this twice as it leads to debug logs duplication.

Before:

##vso[task.debug]exec tool: C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe
##vso[task.debug]exec tool: C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe
##vso[task.debug]arguments:
##vso[task.debug]arguments:
##vso[task.debug]   -c
##vso[task.debug]   -c
##vso[task.debug]   echo hello
##vso[task.debug]   echo hello
[command]C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe -c "echo hello"
hello
##vso[task.debug]Process exited with code 0 and signal null for tool 'C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe'
##vso[task.debug]Process exited with code 0 and signal null for tool 'C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe'

after:

##vso[task.debug]exec tool: C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe
##vso[task.debug]arguments:
##vso[task.debug]   -c
##vso[task.debug]   echo hello
[command]C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe -c "echo hello"
hello
##vso[task.debug]Process exited with code 0 and signal null for tool 'C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe'

@KonstantinTyukalov KonstantinTyukalov marked this pull request as ready for review September 30, 2024 10:38
@KonstantinTyukalov KonstantinTyukalov requested review from a team as code owners September 30, 2024 10:38
@KonstantinTyukalov KonstantinTyukalov merged commit 30fdda7 into master Sep 30, 2024
6 checks passed
@KonstantinTyukalov KonstantinTyukalov deleted the users/KonstantinTyukalov/remove_duplicate_task_debug branch September 30, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants