Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use if constexpr in locale facets #5001

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Use if constexpr in locale facets #5001

merged 4 commits into from
Oct 12, 2024

Conversation

cpplearner
Copy link
Contributor

Towards #189

@cpplearner cpplearner requested a review from a team as a code owner October 3, 2024 08:05
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Oct 3, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 3, 2024
StephanTLavavej
StephanTLavavej reviewed Oct 3, 2024
View reviewed changes
@StephanTLavavej
Copy link
Member

Thanks, this is awesome! 😻 I pushed a small change to further simplify things, consistent with your other changes.

@StephanTLavavej StephanTLavavej removed their assignment Oct 3, 2024
@StephanTLavavej StephanTLavavej mentioned this pull request Oct 3, 2024
Open
@StephanTLavavej StephanTLavavej self-assigned this Oct 11, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5bb81f6 into microsoft:main Oct 12, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for if constexprizing the world! 🌎 🎉 💯

@cpplearner cpplearner deleted the if-constexpr-facet branch October 13, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpplearner @StephanTLavavej