Public Factory Method for Rule Parameter From Type #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
RuleParameter
's type is only known via aType
at runtime, it becomes non-trivial to create a pseudo-object of thatType
in order to create aRuleParameter
. For instance,Activator.CreateInstance
throws when attempting to create astring
It would be ideal if the
RuleParameter
could be created directly from theName
andType
pair as the internal implementation does.In this PR, I elected to create a static factory method over publicizing the constructor to avoid overload confusion of
Name, Value
andName, Type
- theoretically a consumer could be passing in aType
into theobject
constructor, and publicizing the constructor could potentially be a breaking change.