Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP: Use git rev-parse to get last commit sha (#6366) #6375

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

hekota
Copy link
Member

@hekota hekota commented Feb 29, 2024

Do not use git describe, it is using tags which might be out of date and unrelated to the current build and version.

(cherry picked from commit aaab2a7)

Do not use `git describe`, it is using tags which might be out of date
and unrelated to the current build and version.

(cherry picked from commit aaab2a7)
@hekota hekota requested a review from a team as a code owner February 29, 2024 20:59
Copy link
Contributor

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r 9403822342b01188e1f653da4643491163b48cfc..fdb8f60cef2a47b78ea0cc92e0d9983c0f4fac82 utils/version/gen_version.py
View the diff from darker here.
--- gen_version.py	2024-02-29 20:58:53.000000 +0000
+++ gen_version.py	2024-02-29 21:00:35.525233 +0000
@@ -36,10 +36,11 @@
     return output.decode('ASCII').strip()
 
 def is_dirty():
     diff = get_output_of(["git", "diff", "HEAD", "--shortstat"])
     return len(diff.strip()) != 0
+
 
 def get_last_commit_sha():
     try:
         sha = get_output_of(["git", "rev-parse", "--short", "HEAD"])
         if is_dirty():
  • Check this box to apply formatting changes to this branch.

@hekota hekota changed the title Use git rev-parse to get last commit sha (#6366) CP: Use git rev-parse to get last commit sha (#6366) Feb 29, 2024
@hekota hekota merged commit c9660a8 into microsoft:release-1.8.2403 Feb 29, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants