[spirv] add vk::ext_result_id<T> type
#4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiaolu Could you please review this PR? |
|
✅ Build DirectXShaderCompiler 1.0.1072 completed (commit f2ee21ccb9 by @jaebaek) |
sure, will take a look |
jiaolu
reviewed
Jan 18, 2022
|
@jiaolu Thanks! |
sudonatalie
reviewed
Jan 18, 2022
sudonatalie
reviewed
Jan 18, 2022
As a part of HLSL version of GL_EXT_spirv_intrinsics, this commit adds vk::ext_result_id<T> type. We must use it for a variable definition or a function parameter. It means we do not consider it as a physical storage. Instead, it will be a result id of the instruction. Related to microsoft#3919
This reverts commit 2d77432.
jaebaek
force-pushed
the
ext_result_id
branch
from
58d20a2 to
cf70a26
Compare
|
✅ Build DirectXShaderCompiler 1.0.1079 completed (commit 4a379caf14 by @jaebaek) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of HLSL version of GL_EXT_spirv_intrinsics, this commit adds
vk::ext_result_id type. We must use it for a variable definition or
a function parameter. It means we do not consider it as a physical
storage. Instead, it will be a result id of the instruction.
Related to #3919