-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIRV] Add support of [[vk::ext_type_def]] #4068
Conversation
❌ Build DirectXShaderCompiler 1.0.800 failed (commit f577c87138 by @jiaolu) |
0c54275
to
f0eb6d7
Compare
❌ Build DirectXShaderCompiler 1.0.801 failed (commit 1b1de16a62 by @jiaolu) |
❌ Build DirectXShaderCompiler 1.0.802 failed (commit 7cf85d57a7 by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.803 completed (commit 430b3e23f5 by @jiaolu) |
I am really sorry for being late. I am experiencing intensive workloads. I will review it until tomorrow. I know this is a complicated one and I appreciate your strong contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check how to define vk::ext_type
, but could you please address my comments?
Let me know if you think sth of them are unclear (We can have email or video-call communications as well).
@jiaolu I sent a commit to your branch that allows us to put |
✅ Build DirectXShaderCompiler 1.0.871 completed (commit fe5ff96e85 by @jiaolu) |
❌ Build DirectXShaderCompiler 1.0.872 failed (commit 8844a78d1a by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.876 completed (commit 08df266a28 by @jiaolu) |
❌ Build DirectXShaderCompiler 1.0.877 failed (commit 016da2579e by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.879 completed (commit 192642892a by @jiaolu) |
hi, @jaebaek, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late.
LGTM. I have just a last comment.
Thanks!
✅ Build DirectXShaderCompiler 1.0.892 completed (commit f3deab7273 by @jiaolu) |
this is related
#3919