This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Changed path to Program Files directory to a platform dependent X86 version. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeToolsUpdate project was looking for MSBuild in a Program Files directory appropriate for its current architecture. MSBuild is located in X86 version of Program Files.
|
💭 Would be nice to see 👍 |
|
❓ What does CodeToolsUpdate do? |
|
From my first impression I can only say that it registers VS and MSBuild extensions (Task Manager, property pages, post build tasks) in the system during installation. |
|
@hubuk What do you think, should we change to |
|
@sharwell Are you ok with this change? Or you would like to get an answer on your question first? |
|
I can submit this change in a few minutes. |
|
@SergeyTeplyakov @sharwell Changed to Path.Combine. |
SergeyTeplyakov
added a commit
that referenced
this pull request
Nov 5, 2015
Changed path to Program Files directory to a platform dependent X86 version.
|
Hey guys, this fails to compile for me because of a missing closing parenthesis here. |
|
Thanks, Submitted a fix. #290 |
|
@fedotovalex Thanks! I've merged the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeToolsUpdate project was looking for MSBuild in a Program Files directory appropriate for its current architecture. MSBuild is located in X86 version of Program Files.