This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
SQL Collection fix #1292
Merged
SQL Collection fix #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft.Data path. The class is modified to NOT import the system.data namespace now to ensure we rely purely on reflection. This should have been done in the original fix which would have caught this issue there itself.
cijothomas
commented
Oct 14, 2019
| @@ -2,8 +2,6 @@ namespace Microsoft.ApplicationInsights.DependencyCollector.Implementation.SqlCl | |||
| { | |||
| using System; | |||
| using System.Collections.Generic; | |||
There was a problem hiding this comment.
removing this import should have caught the issue earlier. Now we can confirm that we rely purely on reflection via PropertyFetchers.
TimothyMothra
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1291
SQL Listener had references to System.Data types in Microsoft.Data path.
The class is modified to NOT import the system.data namespace now to ensure we rely purely on reflection. This should have been done in the original fix which would have caught this issue there itself.
Fix Issue # .
For significant contributions please make sure you have completed the following items:
Changes in public surface reviewed
Design discussion issue #
CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)
Please follow [these] (/~https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/develop/CONTRIBUTING.md) instructions to build and test locally.