recreated PerfTestApp as springboot application #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misc cleanup
dhaval24
reviewed
Mar 8, 2019
dhaval24
reviewed
Mar 8, 2019
dhaval24
reviewed
Mar 8, 2019
dhaval24
reviewed
Mar 8, 2019
...ava/com/microsoft/applicationinsights/testapps/perf/boot/controllers/FakeRestController.java
Outdated
Show resolved
Hide resolved
dhaval24
reviewed
Mar 8, 2019
...ava/com/microsoft/applicationinsights/testapps/perf/boot/controllers/FakeRestController.java
Outdated
Show resolved
Hide resolved
dhaval24
reviewed
Mar 8, 2019
...ava/com/microsoft/applicationinsights/testapps/perf/boot/controllers/FakeRestController.java
Outdated
Show resolved
Hide resolved
dhaval24
approved these changes
Mar 8, 2019
dhaval24
reviewed
Mar 10, 2019
| @@ -38,11 +38,9 @@ public void run() { | |||
| ? pUrl | |||
| : "http://"+pUrl); | |||
|
|
|||
| CloseableHttpClient client = HttpClients.createDefault(); | |||
| try { | |||
| try (CloseableHttpClient client = HttpClientBuilder.create().disableAutomaticRetries().build()) { | |||
There was a problem hiding this comment.
This is much clearer :) We should make this refactoring in core sdk code base also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this application for testing. I need a springboot version.