Better mapping of cosmos telemetry #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
approved these changes
Feb 13, 2023
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Feb 13, 2023
| @@ -392,16 +396,31 @@ private static void applyDatabaseClientSpan( | |||
| } else { | |||
| type = "SQL"; | |||
| } | |||
| } else if (dbSystem.equals("Cosmos")) { | |||
| // this has special icon in portal (documentdb was the old name for cosmos) | |||
| type = "azure documentdb"; | |||
There was a problem hiding this comment.
we had a long conversation between portal and cosmos team and decided that using RP namespace is the best choice (Microsoft.DocumentDB for client spans, InProc | Microsoft.DocumentDB for internal spans)
If it's not implemented on the portal yet, it should be soon (cc @OsvaldoRosado)
There was a problem hiding this comment.
thx! Microsoft.DocumentDB didn't have an image yet when I tested, but went ahead and changed it to avoid churn on the data 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @lmolkova