Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glowroot => ApacheHttpClient4xInstrumentation#onReturn() is broken for few api methods. #1067

Closed
smathangi opened this issue Sep 24, 2019 · 6 comments · Fixed by #1069
Closed
Assignees
Milestone

Comments

@smathangi
Copy link

smathangi commented Sep 24, 2019

Expected behavior

Instrumentation should work for all execute() methods of HttpClient interface.

Actual behavior

It seems there is a bug in the glowroot's ApacheHttpClient4xInstrumentation glowroot/instrumentation#1
Because of this our application which is using ApacheHttpClient4 throwing errors when integrated with applicationinsights-agent-2.5.0.jar.

Is there a way to disable ApacheHttpClient instrumentation ?

System information

Please provide the following information:

  • Using spring-boot? Yes
  • Additional relevant libraries (with version, if applicable):
    Apache HttpClient : 4.5.8
    applicationinsights-agent : 2.5.0
@trask trask self-assigned this Sep 24, 2019
@trask trask added this to the 2.5.1 milestone Sep 24, 2019
@trask
Copy link
Member

trask commented Sep 24, 2019

Thanks for reporting this!

I'll look into it now.

In the meantime, to disable the instrumentation, try

<ApplicationInsightsAgent>
  <Instrumentation>
    <BuiltIn enabled="true">
      <HTTP enabled="false" />
    </BuiltIn>
  </Instrumentation>
</ApplicationInsightsAgent>

@timja
Copy link
Contributor

timja commented Oct 1, 2019

@trask would it be possible for a release of this?
Today owasp dependency failures came out hitting dependencies of application insights (older versions i.e. 2.3.0), we've had some teams try upgrade to latest and they've hit this bug

@trask
Copy link
Member

trask commented Oct 1, 2019

Hi @timja, thanks for the nudge, we will release 2.5.1-BETA today.

@trask
Copy link
Member

trask commented Oct 2, 2019

2.5.1-BETA is released now

@timja
Copy link
Contributor

timja commented Oct 29, 2019

Any chance of a GA release soon @trask?
We're running the beta on quite a few applications but we get questions often on why we're using a beta...

@trask
Copy link
Member

trask commented Oct 30, 2019

Hi @timja, just released now, thanks again for reporting this!

@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants