Expose org.eclipse.jetty:jetty-servlet in bom.

[wetted]

No description provided.

[timyates]

Do we need to make this managed?

In the other linked PRs to this one, it's jetty-server not jetty-servlet

So could we just expose the version?

I don't know

[sdelamo]

I think @timyates is right. @wetted change this PR to expose only the version.

[sdelamo]

I think @timyates is right. @wetted change this PR to expose only the version.

[timyates]

Actually...thinking about it, I'm wrong...

There's no way in aws to hava a catalog entry for jetty-server with the version from here...

[wetted]

Actually...thinking about it, I'm wrong...

There's no way in aws to hava a catalog entry for jetty-server with the version from here...

@sdelamo @timyates I think there's enough back and forth here that I don't understand what we should be doing.

[timyates]

@sdelamo @wetted How's this 44d2cf5

So here we expose a version and a BOM for jetty...

We can then (in AWS for example) change the libs.versions.toml thusly:

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index cdc245337..0ce4aa60c 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -7,7 +7,6 @@ spock = "2.3-groovy-4.0"

 bouncycastle = '1.70'
 fileupload = '0.0.6'
-jetty = '11.0.20'
 logback-json-classic = '0.1.5'

 micronaut-discovery = "4.2.0"
@@ -88,7 +87,7 @@ bouncycastle-provider = { module = 'org.bouncycastle:bcprov-jdk15on', version.re
 fileupload = { module = 'org.javadelight:delight-fileupload', version.ref = 'fileupload' }
 graal-sdk = { module = 'org.graalvm.sdk:graal-sdk', version.ref = 'graal' }
 jackson-afterburner = { module = 'com.fasterxml.jackson.module:jackson-module-afterburner' }
-jetty-server = { module = 'org.eclipse.jetty:jetty-server', version.ref = 'jetty' }
+jetty-server = { module = 'org.eclipse.jetty:jetty-server' }
 jcl-over-slf4j = { module = 'org.slf4j:jcl-over-slf4j', version.ref = 'slf4j' }
 junit-jupiter-engine = { module = 'org.junit.jupiter:junit-jupiter-engine' }
 junit-jupiter-api = { module = 'org.junit.jupiter:junit-jupiter-api' }

(so we don't declare a Jetty version in there), and then we would need to update the build files with platform dependencies

diff --git a/function-aws-api-proxy-test/build.gradle.kts b/function-aws-api-proxy-test/build.gradle.kts
index 05ef65887..1432c7bef 100644
--- a/function-aws-api-proxy-test/build.gradle.kts
+++ b/function-aws-api-proxy-test/build.gradle.kts
@@ -5,6 +5,7 @@ plugins {
 dependencies {
     api(mn.micronaut.http.server)
     api(projects.micronautFunctionAwsApiProxy)
+    implementation(platform(mnServlet.boms.jetty))
     implementation(libs.jetty.server)
     testImplementation(mn.micronaut.http.client)
     testImplementation(mn.micronaut.jackson.databind)

I think this is where we wanted to end up?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[wetted]

@sdelamo @wetted How's this 44d2cf5

So here we expose a version and a BOM for jetty...

We can then (in AWS for example) change the libs.versions.toml thusly:
...

I think this is where we wanted to end up?

Yeah, I think that looks good. Thanks.