Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set index to false for metric values in ElasticMeterRegistry #2364

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Set index to false for metric values in ElasticMeterRegistry #2364

merged 1 commit into from
Nov 30, 2020

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 27, 2020

This PR changes to set index to false for metric values in ElasticMeterRegistry.

See #1629 (comment)

@izeye izeye mentioned this pull request Nov 27, 2020
Closed
@shakuzen shakuzen added enhancement A general enhancement registry: elastic An ElasticSearch Registry related issue labels Nov 30, 2020
@shakuzen shakuzen added this to the 1.7.0 milestone Nov 30, 2020
shakuzen
shakuzen approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request @izeye, and thank you for making the suggestion @xeraa.

@shakuzen shakuzen merged commit 9a9fb18 into micrometer-metrics:master Nov 30, 2020
@izeye izeye deleted the index-false branch November 30, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
enhancement A general enhancement registry: elastic An ElasticSearch Registry related issue
Projects
None yet
Milestone
1.7.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@izeye @shakuzen