Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Settings: Take product name into MyActivity page #2491

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

DaVinci9196
Copy link
Contributor

@DaVinci9196 DaVinci9196 commented Aug 17, 2024

Fixed the issue in YouTube settings where clicking Manage all history would redirect to Google search history.
Google search history and YouTube Manage all history share the same screenId.

@WSTxda
Copy link

WSTxda commented Aug 20, 2024

Isn't it better to use a history-related link like: https://myactivity.google.com/product/youtube

It should be noted that the option "manage your data on YouTube" should probably open this same link

@mar-v-in mar-v-in added this to the 0.3.4 milestone Aug 27, 2024
@mar-v-in
Copy link
Member

@WSTxda this is what the PR does: When MyActivity page (screen id 547) is requested and a product is set (e.g. YouTube will set product to youtub) replace search in https://myactivity.google.com/product/search with requested product name (creating e.g. https://myactivity.google.com/product/youtube).

@mar-v-in mar-v-in changed the title Fixed the issue in YouTube settings where clicking Manage all history… Account Settings: Take product name into MyActivity page Sep 28, 2024
@mar-v-in mar-v-in merged commit f2479fe into microg:master Sep 28, 2024
1 check passed
WSTxda pushed a commit to WSTxda/MicroG-RE that referenced this pull request Sep 29, 2024
@DaVinci9196 DaVinci9196 deleted the fix_youtube_history branch October 8, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants