Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #78: Add validator command to API #83

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Issue #78: Add validator command to API #83

merged 4 commits into from
Sep 1, 2021

Conversation

vkbo
Copy link
Contributor

@vkbo vkbo commented Aug 31, 2021

Summary:

This PR adds a /vi/validate endpoint to the API that will validate a single file without calling any distributors.

Related issue:

Closes #78

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@vkbo vkbo requested review from mortenwh and johtoblan August 31, 2021 10:27
Copy link
Collaborator

@mortenwh mortenwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one minor thing with a missing docstring... can be merged when fixed

dmci/api/app.py Show resolved Hide resolved
@vkbo vkbo merged commit d41a82c into main Sep 1, 2021
@vkbo vkbo deleted the issue78_api_validate branch September 1, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dry-run functionality
2 participants