Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GunicornPrometheusMetrics #235

Merged
merged 1 commit into from
Oct 4, 2024
Merged

use GunicornPrometheusMetrics #235

merged 1 commit into from
Oct 4, 2024

Conversation

charlienegri
Copy link
Contributor

Summary: use GunicornPrometheusMetrics

Related issue: #220

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@charlienegri
Copy link
Contributor Author

charlienegri commented Oct 3, 2024

@magnarem this exposes the /metrics endpoint correctly at port 9200 (could not use 8000) when run in a container locally but I am not 100% sure if it accounts correctly for the different workers
Screenshot from 2024-10-03 18-57-42

@charlienegri charlienegri marked this pull request as ready for review October 3, 2024 17:01
@charlienegri charlienegri requested a review from magnarem October 3, 2024 17:01
@magnarem
Copy link
Contributor

magnarem commented Oct 4, 2024

I added some comment to issue #220.

Reviewed and accepted and merged this.

Copy link
Contributor

@magnarem magnarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and approved

@magnarem magnarem merged commit 3a55f4f into main Oct 4, 2024
5 checks passed
@magnarem magnarem deleted the gunicorn_prom_exp branch October 4, 2024 08:41
@charlienegri
Copy link
Contributor Author

we might need an extra
EXPOSE 9200
in the Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants