Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.11 to tests, update github actions #116

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

johtoblan
Copy link
Collaborator

@johtoblan johtoblan commented Dec 7, 2022

Summary: Updates github actions to new node.js versions and python test to test versions 3.7 - 3.11

Related issue: Closes #114

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@johtoblan johtoblan requested a review from mortenwh December 7, 2022 12:09
Copy link
Collaborator

@mortenwh mortenwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johtoblan johtoblan merged commit 1a68220 into main Dec 13, 2022
@johtoblan johtoblan deleted the update_github_actions branch December 13, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests to support Python 3.11
2 participants