Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow table auto-layout width processing #245

Closed
Intelligent2013 opened this issue May 21, 2024 · 2 comments
Closed

Slow table auto-layout width processing #245

Intelligent2013 opened this issue May 21, 2024 · 2 comments
Assignees
@Intelligent2013
Labels
bug Something isn't working

Comments

@Intelligent2013
Copy link
Contributor

Source issue: metanorma/metanorma-plateau#2

The Plateau Presentation XML contains 1129 tables and the auto-layout algorithm is working very slow - each table processes a minute.
@Intelligent2013 Intelligent2013 added the bug Something isn't working label May 21, 2024
@Intelligent2013 Intelligent2013 self-assigned this May 21, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma May 21, 2024
Intelligent2013 added a commit that referenced this issue May 21, 2024
@Intelligent2013
tables_only.xsl updated for #245
332aad7
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue May 21, 2024
@Intelligent2013
common xslt code optimization for metanorma/mn2pdf#245
0dce019
@Intelligent2013
Copy link
Contributor Author

The algorithm realized in /~https://github.com/metanorma/iso-2533/issues/20#issuecomment-2030322945:

the columns widths calculates separately for each table

works slowly for the 1000 tables.
I've optimized mn2pdf and common.xsl a bit. It decreased the time for one table to ~8 sec. But the total processing time 1129 * 8sec = 9000sec (2.5h) is very bad.
I need to rethink the big count table processing.

@Intelligent2013 Intelligent2013 mentioned this issue May 21, 2024
Closed
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue May 22, 2024
@Intelligent2013
skip table auto layout for plateau added, metanorma/mn2pdf#245, metan…
b4f08e4 
…orma/metanorma-plateau#2
Intelligent2013 added a commit that referenced this issue May 22, 2024
@Intelligent2013
skip table auto layout for plateau added, #245, metanorma/metanorma-p…
b8120f9 
…lateau#2
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue May 26, 2024
@Intelligent2013
table width algorithm performance optimization, metanorma/mn2pdf#245
36b61fa
Intelligent2013 added a commit that referenced this issue May 26, 2024
@Intelligent2013
table width algorithm performance optimization, #245
20918f7
@Intelligent2013 Intelligent2013 moved this from 🆕 New to 🏗 In progress in Metanorma May 26, 2024
Intelligent2013 added a commit that referenced this issue May 26, 2024
@Intelligent2013
code refactoring, #245
ebe9e00
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue May 26, 2024
@Intelligent2013
Merge pull request #679 from metanorma/table_width_fix
ddcafb2 
table width algorithm performance optimization, metanorma/mn2pdf#245
Intelligent2013 added a commit that referenced this issue May 26, 2024
@Intelligent2013
minor fixing, #245
4f0be7c
Intelligent2013 added a commit that referenced this issue May 26, 2024
@Intelligent2013
Merge pull request #251 from metanorma/table_width_fix
5a3d9d8 
table width algorithm performance optimization, #245
@Intelligent2013
Copy link
Contributor Author

Done in /~https://github.com/metanorma/mn2pdf/releases/tag/v1.90.
Now the processing Plateau document with 1129 tables takes ~1000sec.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Metanorma May 26, 2024
This was referenced Jun 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Intelligent2013 Intelligent2013

Labels
bug Something isn't working
Projects
Metanorma
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Intelligent2013