Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump IPAM to 1.8.1 #2092

Merged
merged 1 commit into from
Nov 20, 2024
Merged

🌱 Bump IPAM to 1.8.1 #2092

merged 1 commit into from
Nov 20, 2024

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Nov 13, 2024 •
edited by tuminoid
Loading

Bump IPAM to 1.8.1

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-1.22.9 branch from 77323cc to ebad9b8 Compare November 13, 2024 12:37
@peppi-lotta peppi-lotta changed the title Bump Golang to 1.22.9 and IPAM to 1.8.1 🌱 Bump Golang to 1.22.9 and IPAM to 1.8.1 Nov 13, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

tuminoid
tuminoid reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not touch go.mod files' go directives. We keep it as low as dependencies allow.

api/go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
hack/fake-apiserver/go.mod Outdated Show resolved Hide resolved
hack/tools/go.mod Outdated Show resolved Hide resolved
test/go.mod Outdated Show resolved Hide resolved
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main

Don't bother running tests when you need to do changes, which invalidate the result.

@tuminoid
Copy link
Member

/hold
until fixed.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-1.22.9 branch from ebad9b8 to dba64ea Compare November 14, 2024 12:56
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

tuminoid
tuminoid reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@tuminoid
Copy link
Member

Golang will be bumped to 1.23.3 by #2047 (merging on going), so this needs to be rebased to be IPAM bump only.
/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 18, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-1.22.9 branch from dba64ea to d86906e Compare November 20, 2024 07:57
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@peppi-lotta
Bump Golang and IPAM
dca63aa 
Signed-off-by: Peppi-Lotta <peppi-lotta.saari@est.tech>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-1.22.9 branch from d86906e to dca63aa Compare November 20, 2024 07:58
@peppi-lotta peppi-lotta changed the title 🌱 Bump Golang to 1.22.9 and IPAM to 1.8.1 🌱 Bump IPAM to 1.8.1 Nov 20, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

/unhold
This is fine now.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
Sunnatillo
Sunnatillo reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@metal3-io-bot metal3-io-bot merged commit 3075761 into metal3-io:main Nov 20, 2024
24 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/Bump-Golang-to-1.22.9 branch November 20, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid tuminoid left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peppi-lotta @tuminoid @metal3-io-bot @Sunnatillo