Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Increasing deletion timeout of cluster #2042

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Oct 16, 2024

What this PR does / why we need it:
After moving to new infra we are seeing flake where test times out while deleting cluster. This PR is increasing cluster delete timeout

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2024
@adilGhaffarDev adilGhaffarDev marked this pull request as ready for review October 16, 2024 10:39
@adilGhaffarDev
Copy link
Member Author

We should backport this to 1.8 and 1.7 too. We see the same failure there too.

@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev adilGhaffarDev changed the title [wip]🌱 Adding more logs to debug cluster deletion failure 🌱 Adding more logs to debug cluster deletion failure Oct 16, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
test/e2e/common.go Outdated Show resolved Hide resolved
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
@adilGhaffarDev adilGhaffarDev changed the title 🌱 Adding more logs to debug cluster deletion failure 🌱 Increasing deletion timeout of cluster Oct 16, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@mquhuy
Copy link
Member

mquhuy commented Oct 17, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
LGTM

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@metal3-io-bot metal3-io-bot merged commit 97d6eb2 into metal3-io:main Oct 17, 2024
24 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-delete-fail/adil branch October 17, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants