[Deets in Sheets]: Relationships tab #52057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rafpaf
changed the title
Graphite Automations"Warn authors when publishing large PRs" took an action on this PR • (01/13/25)1 teammate was notified to this PR based on Raphael Krut-Landau's automation. |
rafpaf
force-pushed
the
mdeets/relationships
branch
2 times, most recently
from
935561e to
5f48d31
Compare
rafpaf
force-pushed
the
mdeets/relationships
branch
2 times, most recently
from
74cdf05 to
5eb7e4b
Compare
rafpaf
changed the title
1 task
rafpaf
force-pushed
the
mdeets/relationships
branch
from
505bfc6 to
9f301fd
Compare
rafpaf
added
the
no-backport
Graphite App
rafpaf
changed the title
rafpaf
force-pushed
the
mdeets/relationships
branch
from
6983233 to
8031e0e
Compare
rafpaf
force-pushed
the
mdeets/relationships
branch
from
8031e0e to
983f713
Compare
sloansparger
requested changes
Jan 21, 2025
.../query_builder/components/view/sidebars/QuestionInfoSidebar/components/ModelUsageDetails.tsx
Outdated
Show resolved
Hide resolved
| export const ToggleFullList = ({ | ||
| isExpanded, | ||
| toggle, | ||
| sliceLength, |
There was a problem hiding this comment.
!nit sliceLength feels a bit odd to me
There was a problem hiding this comment.
I added a bit of documentation
| @@ -19,3 +22,26 @@ export const getIconPropsForSource = ( | |||
| const iconProps = iconModel ? getIcon({ model: iconModel }) : undefined; | |||
| return iconProps; | |||
| }; | |||
|
|
|||
| export const getJoinedTablesWithIcons = (question: Question) => { | |||
There was a problem hiding this comment.
you might someone else to double check you on this part...
There was a problem hiding this comment.
Alex P helped me with this part
rafpaf
force-pushed
the
mdeets/relationships
branch
from
983f713 to
c6aefd4
Compare
sloansparger
approved these changes
Jan 21, 2025
rafpaf
force-pushed
the
mdeets/relationships
branch
from
e237636 to
5a60e06
Compare
e2e tests failed on
|
| File | Test Name |
|---|---|
metrics-dashboard.cy.spec.js |
scenarios > metrics > dashboard > should be possible to add metrics to a dashboard |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Relationships tab to the question info sidesheet that shows where the question/model is used, and which tables are linked to it.