Fix unknown kind github error during deployment
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error originated from the
NewDependencyHandlerfunction. This function is designed to automate the deployment of dependencies, specifically CRDs and controllers, for components so users don’t have to perform these steps manually.Before the function only supported components with
kind: artifacthub, which led to failures when handling components withkind: github.It appears that the kind for Kubernetes components, was recently updated to github, causing the function to break.
Notes for Reviewers
The function logic for
kind:githubstill needs to be implemented. This is just a quick fix.Issue
With Solution
Signed commits