Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Function - registerModels #537

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

humblenginr
Copy link
Member

Description

This PR removes the registerModel function. Entities are registered to the register here -/~https://github.com/meshery/meshkit/blob/master/models/meshmodel/registry/registry.go#L95. This causes redundancy.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Nithish Karthik <nithishkarthik01@gmail.com>
@humblenginr humblenginr changed the title feat: remove redundant function Remove Redundant Function - registerModels Jul 14, 2024
@humblenginr humblenginr merged commit 1803ab0 into meshery:master Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant