-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add counts to model, relationship and component #312
Conversation
Signed-off-by: abdullah1308 <abdullahrafi.1308@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a REST API docs update to accompany this?
@leecalcote after I make the changes to the server endpoints, I'll make the corresponding docs update |
Sounds real good. |
@abdullah1308 Did you make sure meshery-server runs perfectly after these changes? |
are there any changes pending in meshery/meshery as well, from your side? |
@Abhishek-kumar09 yes I'll put up a PR for those in a bit |
Okay, then it needs to be reverted for now, because the changes are stopping mesher-server from starting. |
@abdullah1308 with that PR having been reverted, you can now open up a new PR with that code and incorporate new changes. |
Description
This PR add the ability to get counts for models, relationships and components. This is done to support meshery/meshery#7651
Notes for Reviewers
Signed commits