Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counts to model, relationship and component #312

Merged
merged 1 commit into from
May 13, 2023

Conversation

abdullah1308
Copy link
Contributor

@abdullah1308 abdullah1308 commented May 11, 2023

Description

This PR add the ability to get counts for models, relationships and components. This is done to support meshery/meshery#7651

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: abdullah1308 <abdullahrafi.1308@gmail.com>
@leecalcote leecalcote requested a review from Azanul May 12, 2023 17:50
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a REST API docs update to accompany this?

@abdullah1308
Copy link
Contributor Author

Do we have a REST API docs update to accompany this?

@leecalcote after I make the changes to the server endpoints, I'll make the corresponding docs update

@leecalcote
Copy link
Member

Do we have a REST API docs update to accompany this?

@leecalcote after I make the changes to the server endpoints, I'll make the corresponding docs update

Sounds real good.

@leecalcote leecalcote merged commit 5ae2753 into meshery:master May 13, 2023
@Abhishek-kumar09
Copy link
Member

@abdullah1308 Did you make sure meshery-server runs perfectly after these changes?

@Abhishek-kumar09
Copy link
Member

are there any changes pending in meshery/meshery as well, from your side?

@abdullah1308
Copy link
Contributor Author

are there any changes pending in meshery/meshery as well, from your side?

@Abhishek-kumar09 yes I'll put up a PR for those in a bit

@Abhishek-kumar09
Copy link
Member

Okay, then it needs to be reverted for now, because the changes are stopping mesher-server from starting.

@leecalcote
Copy link
Member

@abdullah1308 with that PR having been reverted, you can now open up a new PR with that code and incorporate new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants