Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] fix the first PR merge comment broken image link #231

Merged
merged 1 commit into from
Oct 11, 2022
Merged

[CI] fix the first PR merge comment broken image link #231

merged 1 commit into from
Oct 11, 2022

Conversation

amit-ksh
Copy link
Contributor

@amit-ksh amit-ksh commented Oct 5, 2022

Signed-off-by: Amit Kumar Sharma ksamit1110@gmail.com

Description

This PR fixes #230

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@amit-ksh
fix the first PR merge broken image link
bea3ce0 
Signed-off-by: Amit Kumar Sharma <ksamit1110@gmail.com>
@welcome
Copy link

welcome bot commented Oct 5, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@afzal442 afzal442 self-requested a review October 6, 2022 05:42
afzal442
afzal442 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@afzal442 afzal442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afzal442 afzal442 added kind/bug Something isn't working area/ci Continuous Integration labels Oct 6, 2022
debasishbsws
debasishbsws approved these changes Oct 6, 2022
View reviewed changes
Copy link

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

@amit-ksh amit-ksh requested review from afzal442 and removed request for afzal442 October 6, 2022 17:22
leecalcote
leecalcote approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @amit-ksh 👍

@leecalcote
Copy link
Member

Thanks, @debasishbsws

@leecalcote leecalcote added the hacktoberfest Happy contributing! label Oct 11, 2022
@leecalcote leecalcote merged commit 7fc9f16 into meshery:master Oct 11, 2022
@welcome
Copy link

welcome bot commented Oct 11, 2022

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@amit-ksh amit-ksh deleted the bug/amit-ksh/230 branch October 11, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debasishbsws debasishbsws debasishbsws approved these changes

@leecalcote leecalcote leecalcote approved these changes

@afzal442 afzal442 Awaiting requested review from afzal442

Assignees
No one assigned
Labels
area/ci Continuous Integration hacktoberfest Happy contributing! kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken image in Welcome message
4 participants
@amit-ksh @leecalcote @afzal442 @debasishbsws