Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped file closing #88

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Jul 2, 2022

Signed-off-by: Ashish Tiwari ashishjaitiwari15112000@gmail.com

Description
The definition and schema files opened weren't being closed properly causing failed registration in some cases where the OS set limit of opened files is exceeded.
This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
@Revolyssup Revolyssup requested a review from leecalcote July 2, 2022 07:35
@leecalcote leecalcote added kind/chore Necessary task service-mesh/consul Issues related to Consul labels Jul 12, 2022
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
@Revolyssup
Copy link
Contributor Author

Revolyssup commented Jul 13, 2022

@leecalcote all green. Lets merge this and make a release.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit ba4b412 into meshery:master Jul 13, 2022
@leecalcote
Copy link
Member

v0.5.7 released. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Necessary task service-mesh/consul Issues related to Consul
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants