Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

54_ttl - allow users to set TTL on DNS Records #57

Merged
merged 2 commits into from
Nov 7, 2023
Merged

54_ttl - allow users to set TTL on DNS Records #57

merged 2 commits into from
Nov 7, 2023

Conversation

bdebyl
Copy link
Contributor

@bdebyl bdebyl commented Nov 7, 2023 •
edited
Loading

Fixes #54

Proposed Changes

  • Adds a new variable to the Terraform module route53_record_ttl (defaults to 300) that is passed via Environment Variable to autoscale.py

Description

Allows users to specify a custom DNS (Route53) TTL for the record(s) created for the Autoscaling Handler

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes. (Note: no tests existed prior to this PR so this is non-applicable)
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).

@bdebyl bdebyl merged commit 51cfc4a into master Nov 7, 2023
@bdebyl bdebyl deleted the 54_ttl branch November 7, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorva-marisomaradhya apoorva-marisomaradhya apoorva-marisomaradhya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Allow users to set TTL on route53 records
2 participants
@bdebyl @apoorva-marisomaradhya