Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-render html to change colors #377

Closed
aleixo opened this issue Jul 4, 2020 · 1 comment
Closed

Re-render html to change colors #377

aleixo opened this issue Jul 4, 2020 · 1 comment
Labels
bug Crush'em all. is:missing template This issue does not comply with our contribution guidelines.

Comments

@aleixo
Copy link

aleixo commented Jul 4, 2020

Hello all

I have been using this lib a while now. It does very well the work. But now i have a requirement that is to change the colors of based on the theme.

For that, for now, i have my styles on classStyles and tagStyles props that will adapt to the theme that i have applied. In order for the styles to be used i have to re-render the complete html that depending on the html size will or not be noticed by the user.

Do you think there is a more efficient solution for that?

Thank you very much.

@jsamr jsamr added the question label Jul 4, 2020
@jsamr jsamr added bug Crush'em all. is:missing template This issue does not comply with our contribution guidelines. and removed question labels Jul 5, 2020
@jsamr jsamr linked a pull request Jul 5, 2020 that will close this issue
@jsamr jsamr added the is:waiting pr A pull request is awaiting reviews to solve the problem. label Jul 5, 2020
@jsamr jsamr closed this as completed in 6e2ed46 Jul 15, 2020
@jsamr jsamr removed the is:waiting pr A pull request is awaiting reviews to solve the problem. label Jul 17, 2020
@jsamr
Copy link
Collaborator

jsamr commented Jul 24, 2020

In version 4.2.2, HTML component will re-render on tagsStyles and classesStyles changes, if this is what you meant.
You can test a pre-release version now, see #385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Crush'em all. is:missing template This issue does not comply with our contribution guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants