Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Updating the dockerfile-production to build with gulp support #1486

Merged

Conversation

lirantal
Copy link
Member

@lirantal lirantal commented Sep 7, 2016

Gulp actually requires the gulp package and it's libraries to be installed, and this goes even if gulp or gulp-cli are installed globally. This is why the build fails.
The fix in this PR mitigates this by updating the Dockerfile-production to hint npm to install all dependencies.

Fixes #1453

@lirantal lirantal self-assigned this Sep 7, 2016
@lirantal lirantal added this to the 0.5.0 milestone Sep 7, 2016
@coveralls
Copy link

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 72.998% when pulling bcec457 on lirantal:fix/dockerfile-production-dependencies into dd80951 on meanjs:master.

@FedeG
Copy link
Contributor

FedeG commented Sep 8, 2016

👍

@lirantal lirantal merged commit 1a274d2 into meanjs:master Sep 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker in production mode fails
3 participants