Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

fix(tests): Reorganized coverage tests #1480

Merged
merged 2 commits into from
Sep 5, 2016

Conversation

hyperreality
Copy link
Contributor

fix(tests): Reorganized coverage tests

Moved coverage configuration from karma.conf to the gulpfile:

  • The server-side coverage tests are already configured in the gulpfile so I think the client-side ones should be too, cleaning up the karma.conf file.
  • The previous method to tell karma to run coverage tests involved flipping an environment variable which karma.conf then read. I suspect that this is what caused client-side Travis builds not to send reports to coveralls

LCOV report file concatenation and sending to coveralls has been moved from the gulpfile to .travis.yml, as per @mleanos suggestion

  • Now coverage tests can be run locally using gulp test:coverage without error if you don't have a coveralls account
  • Unfortunately the Karma coverage summary cannot currently be printed to the console due to a bug (well, it can be printed, but it causes the karma:coverage gulp task to hang for about 30 seconds).

@coveralls
Copy link

coveralls commented Sep 5, 2016

Coverage Status

Coverage increased (+9.8%) to 72.975% when pulling 301abe4 on hyperreality:gulp-coverage into 7be1910 on meanjs:master.

@hyperreality
Copy link
Contributor Author

hyperreality commented Sep 5, 2016

Boom! Looks like it's covering both client and server side tests. Now so long as it doesn't send out 9 more coveralls notifications...

@lirantal lirantal self-assigned this Sep 5, 2016
@lirantal lirantal added this to the 0.5.0 milestone Sep 5, 2016
@lirantal
Copy link
Member

lirantal commented Sep 5, 2016

Cool, thanks!

@lirantal lirantal merged commit 70a3e4c into meanjs:master Sep 5, 2016
@hyperreality hyperreality deleted the gulp-coverage branch November 20, 2016 02:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants