Remove the unsupported Nodes GraphQL library #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix #969 |
The library that had been used to integrate with GitHub's GraphQL APIs is no longer maintained. As the rest of the project uses Rest APIs to integrate with services, there's a fairly mature GitHub Java library, and switching to any other GraphQL library is likely to require as much effort as switching to a Rest implementation, this change is removing the GraphQL implementation and moving to the github-api library bundled within Sonarqube. As GitHub's Rest API does not support minimising comments, old summary comments are being deleted rather than minimised after a new summary comment is added. Additionally, the 'bridging' features used in the github-api library cause issues when mockito attempts to mock/spy a bridged class, so an unbridged version of the library has been specified at the start of the test runtime classpath to allow unit testing using the affected classes. Includes an upgrade to the docker-compose file to use a newer Postgres version and resolve some linting issues.
mc1arke
force-pushed
the
nodes-graphql-removal
branch
from
fa7e9d6 to
94646af
Compare
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library that had been used to integrate with GitHub's GraphQL APIs is no longer maintained. As the rest of the project uses Rest APIs to integrate with services, there's a fairly mature GitHub Java library, and switching to any other GraphQL library is likely to require as much effort as switching to a Rest implementation, this change is removing the GraphQL implementation and moving to the github-api library bundled within Sonarqube. As GitHub's Rest API does not support minimising comments, old summary comments are being deleted rather than minimised after a new summary comment is added. Additionally, the 'bridging' features used in the github-api library cause issues when mockito attempts to mock/spy a bridged class, so an unbridged version of the library has been specified at the start of the test runtime classpath to allow unit testing using the affected classes.
Includes an upgrade to the docker-compose file to use a newer Postgres version and resolve some linting issues.