Works with recent beet version, basic http auth support #4
Conversation
|
Woop woop cool! will look over it tomorrow :) Looks like there is actually some interrest in the music-cyclon app. And actually I see a usage again in my day-to-day use :) |
|
A couple of comments: the password storage is unsafe (and the input is plain text), I'm passing username/password around and maybe a class "Account" would be cleaner. The library subfolder customization is untested. Right now I'm creating the output dir as /$library/$artist/$title_$id.$(lowercase(extension)), I don't know if it's possible to ask beets for a filename (and probably the string must be converted into a path to fix encodings). Also, I'm removing duplicates from the download list because it happened to me that it was trying to download 10 times the same 10 songs. The list -> set -> list thing I'm doing is stupid, it might word using a set by default. |
|
PS: thanks for the app, that has a clean code. I'm not a java dev but it took me a really short time to fix problems and adding things :) |
|
|
||
| // I don't want to support proprietary things |
There was a problem hiding this comment.
Ops sorry XD I forgot to delete it before committing
There was a problem hiding this comment.
Its ok though :) I'm no longer the only user and I dont user poweramp anymore because I'm google apps free :)
There was a problem hiding this comment.
Added a comment on it
| @@ -92,6 +97,10 @@ public BeetsFetcher(String address, Resources resources) { | |||
| for (ArrayList<Item> album : randomAlbums) { | |||
| items.addAll(album); | |||
| } | |||
| // terrible way to remove duplicates | |||
There was a problem hiding this comment.
I think this is ok and very fast way to remove duplicates. It would be cool though if you could remove the List and only use a Set.
There was a problem hiding this comment.
Yes just using the Set everywhere is better
app/src/main/res/xml/preferences.xml
Outdated
| <EditTextPreference | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:inputType="number" |
app/src/main/res/xml/preferences.xml
Outdated
| <EditTextPreference | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:inputType="number" |
app/src/main/res/xml/preferences.xml
Outdated
| <EditTextPreference | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:inputType="number" |
|
Also bump the app version so fdroid can update the app :) |
|
I'll fix those in a new commit and squash everything after the review |
|
@nico202 Ok, but dont squash everything. Squash commits that belong together |
|
Btw does the integration with the beets server still work? :P Can't test it right now, maybe in the evening |
You mean "does it sync"? The answer is "now yes". Can't get input type to be a password, fixed other things, let me know what's missing |
|
Just tested it, works good :) Thanks |
|
Fine, small refactor done, thanks! |
|
Perfect! Can you tag the release? :) |
|
Will do when I push the update to fdroid. Btw if you are interrested in supporting another open source project take a look at https://integreat-app.de/en/ We just won the Google Impact Challange :) |
|
@nico202 I opened a MR for fdroid: https://gitlab.com/fdroid/fdroiddata/merge_requests/3277 |
Hi, I wasn't able to use it with beet 1.4.5, now it's working. Also, in order to prevent having my music public on the internet I added a basic HTTP auth support.
Code quality is low, it's just an hack to get it working, if you are still using it you might use some code