Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Angular v.18 update. (#563) #567

Conversation

giboow
Copy link
Contributor

@giboow giboow commented Jun 4, 2024

Description

Angular v.18 update including:

Angular v.18 update and the other dependencies as well.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Issue Number: #563

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@dodesheide
Copy link

@marcinmajkowski can you please review these pr?

Copy link

@zhandosainabek zhandosainabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for version 18 :)

@JuNe98
Copy link

JuNe98 commented Jun 10, 2024

@giboow can you assign this PR to @mauriciovigolo and I think you should change to feat: notation to fit contributing guidelines :)

@giboow giboow force-pushed the feature/support-angular-v18 branch from dfe0440 to f3a7389 Compare June 10, 2024 07:00
@giboow
Copy link
Contributor Author

giboow commented Jun 10, 2024

@giboow can you assign this PR to @mauriciovigolo and I think you should change to feat: notation to fit contributing guidelines :)

@JuNe98, I've changed my commit message, but I can't assign anyone, I don't have the rights.

@RedWings-R
Copy link

@mauriciovigolo can you please review these pr?

@mauriciovigolo mauriciovigolo self-requested a review June 12, 2024 14:01
@mauriciovigolo mauriciovigolo self-assigned this Jun 12, 2024
@mauriciovigolo mauriciovigolo added enhancement This issue/PR is an enhancement or new feature. dependencies This PR updates a dependency. labels Jun 12, 2024
@mauriciovigolo
Copy link
Owner

mauriciovigolo commented Jun 12, 2024

Sorry for the delay.
I will review and release the next version between today and tomorrow.

Update: I couldn't finish testing the new version. I want to include Keycloak 25 support and I'm doing an investigation to support server-side rendering. I will release the new version this weekend 16.06 - milestone v16.0.0

@mauriciovigolo mauriciovigolo added this to the v.16.0.0 milestone Jun 14, 2024
@mauriciovigolo mauriciovigolo changed the base branch from main to feat/support-angular-v18 June 16, 2024 19:47
@mauriciovigolo mauriciovigolo changed the title Feature: Angular v.18 update. (#563) Feat: Angular v.18 update. (#563) Jun 16, 2024
@mauriciovigolo mauriciovigolo deleted the branch mauriciovigolo:feat/support-angular-v18 June 16, 2024 20:02
@mauriciovigolo mauriciovigolo merged commit 74f2df6 into mauriciovigolo:feat/support-angular-v18 Jun 16, 2024
1 check passed
mauriciovigolo added a commit that referenced this pull request Jun 17, 2024
* Feat: Angular v.18 update. (#563) (#567)

* feat: changes in angular v18, update keycloak v25

---------

Co-authored-by: Philippe Gibert <philippe.gibert@gmail.com>
mauriciovigolo added a commit that referenced this pull request Jun 17, 2024
* Feat: Angular v.18 update. (#563) (#567)

* feat: changes in angular v18, update keycloak v25

---------

Co-authored-by: Philippe Gibert <philippe.gibert@gmail.com>
@mauriciovigolo
Copy link
Owner

keycloak-angular v16 released as planned.

Server-side rendering requires more work in the documentation, example and code. It will be part of the next version.

Thank you @giboow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This PR updates a dependency. enhancement This issue/PR is an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants