Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate manifest.ts #127

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Don't generate manifest.ts #127

merged 1 commit into from
Sep 22, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Sep 18, 2020

Summary

Instead of generating manifest.ts via make apply the code simply reads it from the json file.

We might be able to drop make apply completely in the future.

Ticket Link

None

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Sep 18, 2020
agarciamontoro
agarciamontoro approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 🎉

@hanzei hanzei requested review from jfrerich and removed request for mickmister September 21, 2020 12:08
jfrerich
jfrerich approved these changes Sep 22, 2020
View reviewed changes
Copy link

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the need for make apply would be awesome!

The command is already tied in to the Make commands, but accessing plugin.json as a single source of truth will also be great 🎉

@jfrerich jfrerich removed the 2: Dev Review Requires review by a core committer label Sep 22, 2020
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Sep 22, 2020
@hanzei hanzei merged commit 18d30b5 into master Sep 22, 2020
@hanzei hanzei deleted the drop_manifest branch September 22, 2020 23:14
lieut-data added a commit that referenced this pull request Dec 12, 2023
@lieut-data
Revert "Don't generate manifest.ts (#127)"
f927586 
This reverts commit 18d30b5.
lieut-data added a commit that referenced this pull request Jan 23, 2024
@lieut-data @mickmister
Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (
de0b31b 
#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b5.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarciamontoro agarciamontoro agarciamontoro approved these changes

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @agarciamontoro @jfrerich