Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tee log to admins as bot messages #9

Merged
merged 4 commits into from
Dec 9, 2019
Merged

Added tee log to admins as bot messages #9

merged 4 commits into from
Dec 9, 2019

Conversation

levb
Copy link
Contributor

@levb levb commented Dec 7, 2019

This addition eases the debugging, especially in HA/kubernetes environments, and should be useful for customer support, as well as development. Note that when turned to debug, it will post debug log entries even if the overall server log level is lower.

cc @hanzei to consider as a Helpers feature.

Details:
Adds config settings to turn teeing on/off and control its level and verbosity.
image

With these settings, the output of /msoffice subscribe looks like this,
image

@levb levb added the 2: Dev Review Requires review by a core committer label Dec 7, 2019
@levb levb requested review from cpoile and mickmister and removed request for cpoile and mickmister December 7, 2019 18:34
@levb levb added Work In Progress Not yet ready for review and removed 2: Dev Review Requires review by a core committer labels Dec 7, 2019
@levb levb requested review from mickmister and cpoile December 7, 2019 18:55
@levb levb added 2: Dev Review Requires review by a core committer and removed Work In Progress Not yet ready for review labels Dec 7, 2019
mickmister
mickmister previously approved these changes Dec 9, 2019
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/utils/bot/poster.go Show resolved Hide resolved
cpoile
cpoile previously approved these changes Dec 9, 2019
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about organization, non-blocking.

server/plugin/authorization.go Outdated Show resolved Hide resolved
server/plugin/authorization.go Show resolved Hide resolved
server/plugin/http/oauth2_complete_test.go Show resolved Hide resolved
server/utils/bot/logger.go Show resolved Hide resolved
Copy link
Contributor Author

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why GitHub is requiring me to "leave a comment indicating the requested changes" when I am trying to comment/respond.

@levb levb dismissed stale reviews from cpoile and mickmister via 8dee4b0 December 9, 2019 19:27
@levb levb requested review from cpoile and mickmister December 9, 2019 19:37
server/plugin/authorization.go Show resolved Hide resolved
@mickmister
Copy link
Contributor

/update-branch

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 9, 2019
@levb levb merged commit 80abaaa into mattermost:master Dec 9, 2019
@levb levb deleted the lev-log-to-admins branch December 9, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants